On Tue, 2018-01-09 at 22:00 -0800, Daniel Klco wrote: > Makes sense and I was kind of suspecting this would be the case. To > enable > the ServiceUser Console to work in a separate bundle though, I do > need to > make the Mapping class public and expose the getActiveMappings method > on > the ServiceUserMapper interface as shown below: > > https://github.com/apache/sling-org-apache-sling-serviceusermapper/co > mpare/master...klcodanr:master > > Does that pose any issues? If not I'll go ahead and start on getting > Service User Mapper 1.4.0 and adding the Service User Console bundle. > I'm > assuming this is okay from a naming perspective: > > - Git Repo Name: sling-org-apache-sling-serviceuser-console > - artifactId: org.apache.sling.serviceuser.console > - name: Apache Sling Service User Console
That looks mostly ok to me. I would name it 'webconsole' though instead of 'console', to make it 100% clear. Other than that, I don't think you need the profile addition in the pom.xml, it should be inherited from the parent pom. Thanks, Robert
