DominikSuess commented on a change in pull request #5: SLING-7544 - improving
optimized alias lookup to not block during int…
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r176115729
##########
File path:
src/test/java/org/apache/sling/resourceresolver/impl/mapping/MapEntriesTest.java
##########
@@ -168,6 +172,8 @@ public void test_simple_alias_support() {
});
mapEntries.doInit();
+
+ while(!mapEntries.isAliasMapInitialized()){}
Review comment:
@rombert - I'll be adding timeout to the Test annotation - this is really
kind of a test hack to wait for this to complete. I can't see any use case for
waiting for the alias map in reality so I'm a bit hesitant to add logic to the
MapEntries class just to trigger some waiting test. I'll be checking if there
is some mockito helper to watch out for a certain condition to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
