DominikSuess commented on a change in pull request #5: SLING-7544 - improving
optimized alias lookup to not block during int…
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r176196506
##########
File path:
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
##########
@@ -1027,12 +1044,28 @@ private boolean addEntry(final Map<String,
List<MapEntry>> entryMap, final Strin
*/
private Map<String, Map<String, String>> loadAliases(final
ResourceResolver resolver) {
final Map<String, Map<String, String>> map = new ConcurrentHashMap<>();
- final String queryString = "SELECT sling:alias FROM nt:base WHERE
sling:alias IS NOT NULL";
- final Iterator<Resource> i = resolver.findResources(queryString,
"sql");
- while (i.hasNext()) {
- final Resource resource = i.next();
- loadAlias(resource, map);
- }
+ String queryString = "SELECT sling:alias FROM nt:base WHERE
sling:alias IS NOT NULL";
+ if (this.factory.isForceNoAliasTraversal()) {
+ queryString += " option(traversal fail)";
Review comment:
@catholicon thx for the suggestion, it's a nice attempt but I assume it's a
rather academical case and textoutput also is some kind of implementation
detail that might more easily change - @rombert I just fixed the exception
handling for the non traverse option - I leave it up to you to answer the
question if we should go for the more backward compatible option which requires
text parsing or the option I provided which is "configurable".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
