toniedzwiedz commented on a change in pull request #4: Provide name hints for SDI configuration entries URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4#discussion_r192022625
########## File path: src/main/java/org/apache/sling/dynamicinclude/Configuration.java ########## @@ -97,6 +98,11 @@ static final String PROPERTY_REWRITE_PATH = "include-filter.config.rewrite"; + static final String NAME_HINT_PROPERTY_NAME = "webconsole.configurationFactory.nameHint"; Review comment: That was my first instinct, however, I noticed that other similar members are `static final`, with the default access. I decided to keep it consistent. Shall I make all of them private or do we want to keep them the way they are for the sake of backward compatibility? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
