toniedzwiedz commented on a change in pull request #4: Provide name hints for SDI configuration entries URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4#discussion_r192029469
########## File path: src/main/java/org/apache/sling/dynamicinclude/Configuration.java ########## @@ -97,6 +98,11 @@ static final String PROPERTY_REWRITE_PATH = "include-filter.config.rewrite"; + static final String NAME_HINT_PROPERTY_NAME = "webconsole.configurationFactory.nameHint"; Review comment: @JEBailey this class still uses the SCR annotations. A rewrite should be fairly straightforward but that sounds like a relatively major version change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
