Hi Roy, I think Joerg lays out a few scenarios in SLING-7613 where there is a distinction between loginService* and loginAdministrative. But that's not really my point :)
All I'm trying to say is that if we are going to continue to have a whitelist, we need a way to tell the developer that when they use loginAdministrative some extra step is necessary. To my knowledge, deprecation is the most universal way to do that. Regards, Justin On Tue, Jul 17, 2018 at 9:45 AM Roy Teeuwen <[email protected]> wrote: > Hey Justin, > > How would this be any different from using the getServiceResourceResolver > though? This also needs additional work to actually create the service user > and make a service mapping config for it. > Not that I am disagreeing with what you are saying because I think the > service user is also a bit too complex sometimes > > Greets > Roy > > > On 17 Jul 2018, at 15:43, Justin Edelson <[email protected]> > wrote: > > > > +1 to the idea of removing the deprecation > > -0 on the PR > > > > Without the deprecation, how will a developer know that they need to > > configure the whitelist? While the deprecation wasn't perfect, at least > it > > gave the developer the sense that they were doing something which should > be > > avoided. It is unfortunate that deprecation in Java is such a binary > > concept, but it is what it is. > > > > I think we have two choices: > > > > 1. Go back to the way things were before -- no deprecation, no whitelist > > 2. Keep the deprecation and whitelist and improve the JavaDoc > > > > No deprecation and keeping the whitelist just seems like a recipe for > > confusion. > > > > Justin > > > > On Tue, Jul 17, 2018 at 8:55 AM Robert Munteanu <[email protected]> > wrote: > > > >> Hi, > >> > >> Following dev@sling discussions [1] and Jira issue [2] I've filed a PR > >> to un-deprecate loginAdministrative [3]. > >> > >> Comments/reviews are most welcome, I plan to merge this next Monday. > >> > >> Thanks, > >> > >> Robert > >> > >> [1]: https://issues.apache.org/jira/browse/SLING-7613 > >> [2]: > >> > http://apache-sling.73963.n3.nabble.com/Deprecation-of-SlingRepository-loginAdministrative-td4081024.html > >> [3]: https://github.com/apache/sling-org-apache-sling-jcr-api/pull/1 > >> > >
