rr040 commented on issue #7: create MissingElementsException only if there is 
at least one missing element
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/7#issuecomment-418732719
 
 
   The creation of an exception is magnitudes more expensive than standard java 
objects like `ArrayList`. But you are right: The creation of the list itself 
could be optimized, too.
   
   The changes have been made based on version 1.4.4 since this is used in our 
production environment. I will rebase the branch to master to avoid the merge 
conflicts shown above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to