[
https://issues.apache.org/jira/browse/SLING-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644630#comment-16644630
]
ASF GitHub Bot commented on SLING-7932:
---------------------------------------
bosschaert commented on issue #4: SLING-7932 - Use Regex to parse mvn GAVs and
URLs
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/4#issuecomment-428486353
Hi @simonetripodi I like the unit tests in this pull request, but I'm
wondering about the code changes. I'm not entirely sure the regex are that much
better/easier than what was there before. And they are most likely not faster.
I would be inclined to take just the tests from this pull request (assuming
they work with the current code) and leave the actual code changes the way they
are...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use Regex to parse mvn GAVs and URLs
> ------------------------------------
>
> Key: SLING-7932
> URL: https://issues.apache.org/jira/browse/SLING-7932
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Trivial
>
> Current implementations work, but they can become a little easier to maintain
> by replacing few lines of manual implemented parsers, with smart regex.
> Pull Request is coming and new tests will be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
