[
https://issues.apache.org/jira/browse/SLING-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645363#comment-16645363
]
ASF GitHub Bot commented on SLING-7932:
---------------------------------------
simonetripodi commented on issue #4: SLING-7932 - Use Regex to parse mvn GAVs
and URLs
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/4#issuecomment-428675833
Cool! :)
As a side note, current parser implementation needs to be adjusted, while
for an input like
`group.a : artifact.b : zip : foo : 1.0`
the regexp would reject it, for the current parser is still a valid input -
and unit tests would fail
/CC @bdelacretaz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use Regex to parse mvn GAVs and URLs
> ------------------------------------
>
> Key: SLING-7932
> URL: https://issues.apache.org/jira/browse/SLING-7932
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Trivial
>
> Current implementations work, but they can become a little easier to maintain
> by replacing few lines of manual implemented parsers, with smart regex.
> Pull Request is coming and new tests will be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
