[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679968#comment-16679968
]
ASF GitHub Bot commented on SLING-8032:
---------------------------------------
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO
which is able to validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959205
##########
File path: src/main/java/org/apache/sling/feature/maven/Preprocessor.java
##########
@@ -404,6 +455,7 @@ public Feature provide(final ArtifactId id) {
// "external" dependency, we can already resolve it
final File featureFile =
ProjectHelper.getOrResolveArtifact(info.project, env.session,
env.artifactHandlerManager, env.resolver, id).getFile();
+ checkFeatureFileValidation(featureFile);
Review comment:
I think we should not validate external features as these are released in
maven already and therefore should be validated already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> ------------------------------------------------------------------------------
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
