[
https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679626#comment-16679626
]
ASF GitHub Bot commented on SLING-8032:
---------------------------------------
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to
validate JSON Feature file against the JSON Schema
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436962821
@cziegeler there is one problem on accessing to Feature files via
`ProjectHelper#getFeatures`: they are parsed. So, if our internal JSON parser
detects a violation, there will be no chance the Feature file will ever be
validated due to runtime errors, i.e.:
```
[main] [ERROR] Internal error: java.lang.RuntimeException: Unable to read
feature
/Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json:
/Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json
: Key model-version is not one of the allowed types [class java.lang.String] :
class java.lang.Long -> [Help 1]
org.apache.maven.InternalErrorException: Internal error:
java.lang.RuntimeException: Unable to read feature
/Users/stripodi/Documents/cq-workspace/sling-slingfeature-maven-plugin/target/it/schema-validation-ko/src/main/features/invalid-feature.json
```
Any idea on how to work around this? TIA!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add a MOJO which is able to validate JSON Feature file against the JSON Schema
> ------------------------------------------------------------------------------
>
> Key: SLING-8032
> URL: https://issues.apache.org/jira/browse/SLING-8032
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> While SLING-7990 contributed the Schema definition, I would like to
> contribute a simple MOJO which is able to validate Feature files against the
> Schema.
> JSON Schema validation does not fit as an {{AnalyserTask}} implementation,
> since {{Feature}} instances are parsed already here, anyway the {{Analyser}}
> takes in charge semantic analysis, while JSON Schema validation is is strict
> about syntax and structure, this is why I would have a separated MOJO which
> can be optionally enabled.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
