[
https://issues.apache.org/jira/browse/SLING-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684944#comment-16684944
]
David Bosschaert commented on SLING-8100:
-----------------------------------------
+1 on the changes above, [~cziegeler].
In the description it states: "a non-complete feature may not be launched, so
don't try to do that" although that is weakened later in the description - so
I'm not sure what that sentence does there.
In any case my opinion on this is that the launcher should not be prevented
from trying to launch a feature that is not complete.
The complete flag on the feature tells someone that it can be run, it's a
guarantee of some sort. However if you try to add something to that it's not
complete any more. I think this even holds for adding another complete feature
to it. So in that case you'd lose that guarantee that it will run, but it might
still be desirable to at least attempt to run it, for example when you want to
add some monitoring functionality as pointed out by [~rombert] on the [email
thread|https://lists.apache.org/thread.html/898ffedea0850efa8cbe1ee2697f367f2ea5de3858fd79ec35354e65@%3Cdev.sling.apache.org%3E].
I think there are other cases where you may want to take the 'risk' of
launching a feature that may not have been marked as complete. If we want add
some 'protection' to this we could consider adding a flag to the launcher that
needs to be set if you want to launch a feature that is not marked as complete.
> Allow a feature to be declared as "complete"
> --------------------------------------------
>
> Key: SLING-8100
> URL: https://issues.apache.org/jira/browse/SLING-8100
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Priority: Blocker
> Fix For: slingfeature-maven-plugin 1.0.0, Feature Model 0.2.2,
> Feature Model IO 0.2.2
>
>
> This is collected from a thread on the mailing list:
> - a complete feature is self-contained, therefore all requirements must be
> satisfied
> - a non-complete feature may not be launched, so don't try to do that
> - for launching, a complete feature can be used together with both, non
> complete and complete features; it must also be possible to use a set of non
> complete features for launching, together they might form a complete feature.
> Or in other words, the launcher does not care about the complete flag
> - for validation we could add that framework launch properties can only be
> set for a complete feature
> - if features are assembled, the resulting feature is only marked as complete
> if all features used to assemble the feature are complete
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
