Thanks for confirming, Andy! After some further digging I can confirm that Carsten is right, and we don't need releases for the extensions that weren't modified. Even though these are included as part of the slingfeature-maven-plugin at runtime, Maven is smart enough to pick the latest version of the dependencies. So that saves us from having to release those.
I'm planning to kick off the release tomorrow (Wednesday). If SLING-8541 is done by then I'll include it. Otherwise we can release the slingfeature-maven-plugin some time later. Best regards, David On Mon, 29 Jul 2019 at 18:01, Andreas Schaefer <[email protected]> wrote: > SLING-8479: I provided a fix for that and it was merged into master so I > marked that ticket as resolved. > > SLING-8483: I do not think this is a high priority for this release. > > Cheers - Andy > > > On Jul 29, 2019, at 8:24 AM, David Bosschaert < > [email protected]> wrote: > > > > Hi Carsten, > > > > On Fri, 26 Jul 2019 at 17:34, Carsten Ziegeler <[email protected]> > wrote: > > > >> > >> +1 for a release. > >> > >> The analyser, modelconverter, launcher have open issues. Not sure how > >> important they are. > >> > > > > For the analyser, I think we can postpone SLING-8594, maybe the analyser > > described in this issue is already covered in another way. I've move the > > issue for the moment to 1.0.8. > > > > For the model converter, @Andy Schaefer do you think SLING-8479 is > urgent? > > If so would you be able to contribute a patch? > > For the launcher, @Andy Schaefer do you think SLING-8483 is urgent? If so > > would you be able to contribute a patch? > > > > Other than these 3 there are no open issues on he analyser, > modelconverter > > and launcher. > > > > > >> > >> Both extensions (apiregions and content) have no issues at all, so I > >> don't think we need a release. Unless the issues are not in jira of > course. > >> > > > > On this topic, there have been changes in the core Feature Model, and > these > > extensions pick the core Feature Model up via Maven dependencies when > they > > are run in a Maven context. Therefore I think we need to update their > > dependencies to the latest Feature Model, otherwise the problem arises > that > > different Feature Model releases end up on the same classpath in Maven. > And > > given the update of the dependency they need a new release. > > In an OSGi runtime you wouldn't have this problem, but since this a flat > > classpath in Maven I think we need a release of these. > > > > Or is there a better way to handle this? > > > > > >> The slingstart plugin has no issues for the upcoming release either. But > >> I assume it depends on some of the other modules? > >> > > > > Yes same classpath issue as described for the extensions... > > > > > >> The slingfeature plugin has one open issue, SLING-8541, which I would > >> like to get resolved before a release. As soon as the proposed solution > >> is agreed on, I can implement it. > > > > > > I'll wait for the discussion on SLING-8541 to conclude. > > > > Best regards, > > > > David > >
