Hi Konrad Thanks for the reference... that helps indeed. Any hint regarding coding style? I found a super old thread on this list that essentially concluded that this is a controversial topic.... sure... but I don't have a strong preference in either way. At the end of the day I only wish to make the repo-init code consistent and easier to read... I have no issue getting used to a different style in a different project and just want to avoid reformatting the code and being told the Sling way was slightly different.
Kind regards Angela ________________________________ From: Konrad Windszus <[email protected]> Sent: Tuesday, November 12, 2019 10:01 AM To: [email protected] <[email protected]> Subject: Re: coding style and annotations Hi Angela, regarding Null annotation look at https://sling.apache.org/documentation/development/null-analysis.html <https://sling.apache.org/documentation/development/null-analysis.html>. We use the same annotations as Jackrabbit now. Thanks, Konrad > On 12. Nov 2019, at 09:56, Angela Schreiber <[email protected]> wrote: > > hi sling devs > > when writing patches for the repo init recently, i noticed that there is some > inconsistency in the formatting and that the code doesn't come with > notnull/nullable annotations, which leads to a quite some extra checks for > null, though the input will never be null. > > having said that: is there an official coding style that i should follow when > fixing the formatting inconsistencies? are notnull/nullable annotiations > being used in the sling project? > > kind regards > angela
