Hi Angela, (sorry for previous incomplete reply, I blame flaky train connections...)
On Tue, Nov 12, 2019 at 11:02 AM Angela Schreiber <[email protected]> wrote: > ...Any hint regarding coding style? I found a super old thread on this list > that essentially > concluded that this is a controversial topic.... I think we still don't have a coding style and as you say if modules have slightly different styles it's best to adapt to the "local" style. I vaguely remember that we agreed on minimal style constraints, indent using spaces (2 or 4? not sure, would adapt to local style) and apart from that follow the (old) Sun code conventions [1]. As for repoinit, I wrote a good part of that code and switched IDEs a few times so there might be inconsistencies in indentation. For me the most important thing is to avoid mixing style "fixes" with actual code changes, i.e. isolate style fixes in specific commits so that people who want to review the code know that they can safely ignore those. -Bertrand [1] https://www.oracle.com/technetwork/java/codeconventions-150003.pdf
