kwin commented on a change in pull request #6: SLING-9172 - adding support for
property sling.installer.multiversion…
URL:
https://github.com/apache/sling-org-apache-sling-installer-core/pull/6#discussion_r388216387
##########
File path:
src/main/java/org/apache/sling/installer/core/impl/tasks/BundleTaskCreator.java
##########
@@ -71,14 +71,17 @@
private BundleBlackList bundleBlacklist;
+ private boolean isMultiVersion;
+
/**
* @see
org.apache.sling.installer.core.impl.InternalService#init(org.osgi.framework.BundleContext,
org.apache.sling.installer.api.ResourceChangeListener, RetryHandler)
*/
@Override
public void init(final BundleContext bc, final ResourceChangeListener
listener, final RetryHandler retryHandler) {
this.bundleContext = bc;
this.retryHandler = retryHandler;
-
+
+ this.isMultiVersion =
Boolean.valueOf(bc.getProperty("sling.installer.multiversion")) ? true : false;
Review comment:
This way this is a global flag. What about a flag per bundle? That way one
can decide per bundle whether it is supposed to exist in multiple versions or
not. One could add that information to the task attributes and the JCR/File
Provider could decide how to populate that attribute (e.g. via Bundle Manifest
Header or via some filename pattern).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
