cziegeler commented on a change in pull request #6: SLING-9172 - adding support
for property sling.installer.multiversion…
URL:
https://github.com/apache/sling-org-apache-sling-installer-core/pull/6#discussion_r388259400
##########
File path:
src/main/java/org/apache/sling/installer/core/impl/tasks/BundleTaskCreator.java
##########
@@ -71,14 +71,17 @@
private BundleBlackList bundleBlacklist;
+ private boolean isMultiVersion;
+
/**
* @see
org.apache.sling.installer.core.impl.InternalService#init(org.osgi.framework.BundleContext,
org.apache.sling.installer.api.ResourceChangeListener, RetryHandler)
*/
@Override
public void init(final BundleContext bc, final ResourceChangeListener
listener, final RetryHandler retryHandler) {
this.bundleContext = bc;
this.retryHandler = retryHandler;
-
+
+ this.isMultiVersion =
Boolean.valueOf(bc.getProperty("sling.installer.multiversion")) ? true : false;
Review comment:
I think we can go with a global switch first, if the use case for more fine
grained handling comes up it can be built on top of this.
The PR has a lot of formatting changes. Please remove them so we can focus
on just the real code changes. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
