etugarev commented on a change in pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447483580



##########
File path: 
src/test/java/org/apache/sling/graphql/core/mocks/URLScalarConverter.java
##########
@@ -41,4 +41,14 @@
         final String testPrefix = getClass().getSimpleName() + " says:";
         return testPrefix + (value == null ? null : value.toExternalForm());
     }
+
+    @Override
+    public String getName() {

Review comment:
       we have name and description in `SlingScalarConverter` here it's not yet 
implemented




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to