stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651771074
Also, in addition to my previous comment: IMHO scalars should not be defined globally, but per endpoint. Typically, they are part of the schema, and two schemas might use different implementations of a scalar with the same name. A typical user-defined scalar could be something around `Date` - with subtle differences for different schemas. While AFAIU the currently proposed change doesn't take that into account, it could be easily extended to pass the endpoint resource to consider for creating the list of scalars. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
