bosschaert commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#discussion_r461494313
##########
File path: pom.xml
##########
@@ -58,8 +58,13 @@
</goals>
<configuration>
<bnd><![CDATA[
-Bundle-Name: ${project.name} (No embedded dependencies)
+Bundle-Name: ${project.name} (Framework Fragment, No embedded dependencies)
Bundle-SymbolicName: ${project.artifactId}.nodeps
+ExtensionBundle-Activator: org.apache.sling.javax.activation.internal.Activator
+Export-Package:
javax.activation;version="0.0.0",com.sun.activation.registries;version="0.0.0",com.sun.activation.viewers;version="0.0.0"
Review comment:
Hi @kwin, my updated pr will not embed any more thanks to your link to
https://groups.google.com/forum/#!topic/bndtools-users/NAdU0_X8OKY for the bnd
instructions.
I agree that updating what is exported by the system bundle is a good idea.
However I would still like to have the exports as defined by this PR in the
bundle/fragment as I'd like to be able to run it with already released versions
of Sling.
##########
File path: pom.xml
##########
@@ -72,7 +77,9 @@ Bundle-SymbolicName: ${project.artifactId}.nodeps
<bnd><![CDATA[
-includeresource:@jakarta.activation-[0-9.]*(-SNAPSHOT)?.jar
# version automatically determined from the MANIFEST.MF of the
jakarta.activation.jar
+Bundle-Activator: org.apache.sling.javax.activation.internal.Activator
Review comment:
The nodeps bundle is a framework extension fragment. That one needs a
different header: `ExtensionBundle-Activator` instead of `Bundle-Activator`, so
I couldn't use the annotation for the 2 ways in which the activator was used.
The actual interface to be implemented by the Extension Bundle Activator is
the same as the normal Bundle Activator.
##########
File path: pom.xml
##########
@@ -72,7 +77,9 @@ Bundle-SymbolicName: ${project.artifactId}.nodeps
<bnd><![CDATA[
-includeresource:@jakarta.activation-[0-9.]*(-SNAPSHOT)?.jar
# version automatically determined from the MANIFEST.MF of the
jakarta.activation.jar
+Bundle-Activator: org.apache.sling.javax.activation.internal.Activator
Review comment:
The nodeps variant is a framework extension fragment. That one needs a
different header: `ExtensionBundle-Activator` instead of `Bundle-Activator`, so
I couldn't use the annotation for the 2 ways in which the activator was used.
The actual interface to be implemented by the Extension Bundle Activator is
the same as the normal Bundle Activator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
