kwin commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#discussion_r461480462
##########
File path: pom.xml
##########
@@ -58,8 +58,13 @@
</goals>
<configuration>
<bnd><![CDATA[
-Bundle-Name: ${project.name} (No embedded dependencies)
+Bundle-Name: ${project.name} (Framework Fragment, No embedded dependencies)
Bundle-SymbolicName: ${project.artifactId}.nodeps
+ExtensionBundle-Activator: org.apache.sling.javax.activation.internal.Activator
+Export-Package:
javax.activation;version="0.0.0",com.sun.activation.registries;version="0.0.0",com.sun.activation.viewers;version="0.0.0"
Review comment:
This will embed. I would rather clean what is exported by the system
bundle
(https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E)
##########
File path: pom.xml
##########
@@ -72,7 +77,9 @@ Bundle-SymbolicName: ${project.artifactId}.nodeps
<bnd><![CDATA[
-includeresource:@jakarta.activation-[0-9.]*(-SNAPSHOT)?.jar
# version automatically determined from the MANIFEST.MF of the
jakarta.activation.jar
+Bundle-Activator: org.apache.sling.javax.activation.internal.Activator
Review comment:
Why was the annotation from
https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4/files#diff-647f7f295a3a772b13eaaa75470004f7L52
not working?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
