If this is about my PR https://github.com/apache/solr/pull/641 then I'm happy to add a JIRA for it. I initially said that I wasn't sure if it was big enough to warrant an issue because it was almost entirely test changes, and even then not really functional changes. But it's 200 lines of difference, so that's probably well past the "minor change" territory.
I don't think there is a written consensus on this, but it's come up a few times on the mailing list before. I don't think we ever reached consensus there either. Mike On Wed, Feb 16, 2022 at 2:09 AM Ishan Chattopadhyaya < [email protected]> wrote: > IMO, any code change should have a JIRA and CHANGES.txt. Substantial ref > guide changes should have a JIRA. > Refactoring should definitely get a JIRA, I'll be surprised if any > refactoring has happened without a JIRA. > > On Wed, Feb 16, 2022 at 12:52 PM Eric Pugh < > [email protected]> wrote: > >> Hi all! Do we have a written definition of what requires a JIRA and/or >> an entry in CHANGES.txt? Something that could go in our developer docs? >> >> Is there a consensus on this? For example, changes to documentation >> typically have NOT gone into the CHANGES.txt file. It appears that some >> refactoring don’t need a JIRA issue as well. >> >> Thoughts on this? >> >> >> Eric >> >> _______________________ >> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467 >> | http://www.opensourceconnections.com | My Free/Busy >> <http://tinyurl.com/eric-cal> >> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> >> This e-mail and all contents, including attachments, is considered to be >> Company Confidential unless explicitly stated otherwise, regardless >> of whether attachments are marked as such. >> >>
