The approach I've always used is: any change to the codebase needs a JIRA. Any change a user would care about (in the most liberal sense) needs a changes.txt entry. Refactoring that doesn't impact APIs (such as changes to tests) doesn't need a changes.txt entry. In general it's rare for me to make a change to Solr and not put in changes.txt but I also don't do as much refactoring of internals as Mike does ;-)
On Wed, Feb 16, 2022 at 11:07 AM Eric Pugh <[email protected]> wrote: > > It wasn’t just your PR, there has been a couple times when I was kind of on > the fence and not sure. > > On Feb 16, 2022, at 6:45 PM, Mike Drob <[email protected]> wrote: > > If this is about my PR https://github.com/apache/solr/pull/641 then I'm happy > to add a JIRA for it. I initially said that I wasn't sure if it was big > enough to warrant an issue because it was almost entirely test changes, and > even then not really functional changes. But it's 200 lines of difference, so > that's probably well past the "minor change" territory. > > I don't think there is a written consensus on this, but it's come up a few > times on the mailing list before. I don't think we ever reached consensus > there either. > > Mike > > On Wed, Feb 16, 2022 at 2:09 AM Ishan Chattopadhyaya > <[email protected]> wrote: >> >> IMO, any code change should have a JIRA and CHANGES.txt. Substantial ref >> guide changes should have a JIRA. >> Refactoring should definitely get a JIRA, I'll be surprised if any >> refactoring has happened without a JIRA. >> >> On Wed, Feb 16, 2022 at 12:52 PM Eric Pugh <[email protected]> >> wrote: >>> >>> Hi all! Do we have a written definition of what requires a JIRA and/or >>> an entry in CHANGES.txt? Something that could go in our developer docs? >>> >>> Is there a consensus on this? For example, changes to documentation >>> typically have NOT gone into the CHANGES.txt file. It appears that some >>> refactoring don’t need a JIRA issue as well. >>> >>> Thoughts on this? >>> >>> >>> Eric >>> >>> _______________________ >>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | >>> http://www.opensourceconnections.com | My Free/Busy >>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >>> This e-mail and all contents, including attachments, is considered to be >>> Company Confidential unless explicitly stated otherwise, regardless of >>> whether attachments are marked as such. >>> > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com | My Free/Busy > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
