Can you tell the benefit, cost, risk and ETA for a Lucene 9.1 upgrade? I'm not able to judge before I know.
Yea, RC2 will likely fail due to SQL. But it is valuable for people to continue testing RC2 and potentially find other bugs, so we avoid too many RCs... So I'll leave the vote open a bit longer, to collect more -1's :) Jan > 31. mar. 2022 kl. 14:35 skrev Ishan Chattopadhyaya > <[email protected]>: > > If this vote is going to fail, can we re-spin based on Lucene 9.1? > > On Thu, Mar 31, 2022 at 5:55 PM Joel Bernstein <[email protected] > <mailto:[email protected]>> wrote: > Here is the jira https://issues.apache.org/jira/browse/SOLR-16131 > <https://issues.apache.org/jira/browse/SOLR-16131>. > > My official vote for the RC: > > -1 > > > Joel Bernstein > http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/> > > > On Thu, Mar 31, 2022 at 4:15 AM Jan Høydahl <[email protected] > <mailto:[email protected]>> wrote: > Joel, > > I could reproduce the error > > Failed to load JDBC driver for > > 'org.apache.solr.handler.sql.CalciteSolrDriver' > > And I see that JDBCStream uses a plain Class.forName(driverClassName); to > fail early if the driver is wrong. > > The sql module is loaded: > > o.a.s.c.NodeConfig Added module sql. > > libPath=...solr-9.0.0/solr/packaging/build/solr-9.0.0/modules/sql/lib with > > 9 libs > > I wonder if we need to use SolrResourceLoader to load the class in order to > find classes in sharedLib. But JDBCStream is in solrj while ResourceLoader is > in core... Hmm > > Please file an issue for this, and cast your formal vote. > > Jan > >> 31. mar. 2022 kl. 02:57 skrev Joel Bernstein <[email protected] >> <mailto:[email protected]>>: >> >> I tried adding the module in the solr.in.sh <http://solr.in.sh/> and it >> can't find the SQLHandler after starting up. So the sql module appears to >> not be working. >> >> "error":{ >> "metadata":[ >> "error-class","org.apache.solr.common.SolrException", >> "root-error-class","java.lang.ClassNotFoundException"], >> "msg":" Error loading class 'solr.SQLHandler'", >> >> >> Joel Bernstein >> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/> >> >> >> On Wed, Mar 30, 2022 at 8:39 PM Joel Bernstein <[email protected] >> <mailto:[email protected]>> wrote: >> I tried loading the sql module but ran into this error when running a sql >> query: >> >> Failed to load JDBC driver for >> 'org.apache.solr.handler.sql.CalciteSolrDriver' >> >> I loaded the module using system prop from startup command line: >> >> bin/solr start -c -Dsolr.modules=sql >> >> >> >> >> >> Joel Bernstein >> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/> >> >> >> On Wed, Mar 30, 2022 at 8:16 PM Jan Høydahl <[email protected] >> <mailto:[email protected]>> wrote: >> I found a minor glitch. >> >> In solr-exporter, the default config solr-exporter-config.xml still uses >> solr_metrics_core_replication_master as key for the >> REPLICATION./replication.isLeader metric. >> >> In 8.x the metrics was named REPLICATION./replication.isMaster and >> REPLICATION./replication.isSlave, but renamed to isLeader / isFollower in >> 9.0. >> The prometheus key for follower is correctly renamed as >> solr_metrics_core_replication_follower already. >> I think the master -> leader should also have been done. >> >> However I cannot see it being referenced in Grafana dashboard or elsewhere, >> so probably not worth a respin, we can do it in 9.1. >> >> Jan >> >> > 30. mar. 2022 kl. 20:53 skrev Jan Høydahl <[email protected] >> > <mailto:[email protected]>>: >> > >> > Please vote for release candidate 2 for Solr 9.0.0 >> > >> > The artifacts can be downloaded from: >> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 >> > >> > <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2> >> > >> > You can run the smoke tester directly with this command: >> > >> > python3 -u dev-tools/scripts/smokeTestRelease.py \ >> > https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 >> > >> > <https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2> >> > >> > You are encouraged to do an extra thorough test and manual inspection >> > beyond >> > running the smoketester, since this is a major release. >> > >> > You can build a release-candidate of the official docker image using the >> > following command: >> > >> > DIST_BASE=https://dist.apache.org/repos/dist/dev/solr >> > <https://dist.apache.org/repos/dist/dev/solr> && \ >> > RC_FOLDER=solr-9.0.0-RC2-rev-e7a6447013008a70a4f40fcfd793fe3e2dcf37c2 && \ >> > docker build $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \ >> > --build-arg SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \ >> > -t solr-rc:9.0.0-2 >> > >> > The vote will be open for at least 72 hours i.e. until 2022-04-02 19:00 >> > UTC. >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove (and reason why) >> > >> > Here is my +1 >> > >> > SUCCESS! [0:53:16.741542] >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> <mailto:[email protected]> >> For additional commands, e-mail: [email protected] >> <mailto:[email protected]> >> >
