I'd suggest #2 because there's no point moving forward with a release, then announcing the issues with it or confusing users with a missing release announcement.
On Fri, Apr 15, 2022 at 8:53 AM Houston Putman <[email protected]> wrote: > So I guess we need to make a decision everyone. Do we: > > 1. Continue with the release to make sure that everything is there > that should be, but skip announcing it (Because we know there are issues). > Then immediately start the 9.0.1 release with the necessary fixes. > 2. Stop this release, remove the release artifacts in dist.apache.org > and also delete the 9.0.0 git tag. (not sure how feasible either of these > are). Then start an RC4 for 9.0.0, with the necessary fixes. > > > I guess, could everyone weigh in with their opinion? This is a sticky > situation and I don't want to move forward without consensus. > > - Houston > > > On Wed, Apr 13, 2022 at 6:06 PM Houston Putman <[email protected]> wrote: > >> You’re right mike, that slipped my mind. >> >> On Wed, Apr 13, 2022 at 6:05 PM David Smiley <[email protected]> wrote: >> >>> This definitely needs to be addressed; basic working Maven coordinates >>> are important. Next time I guess we need to validate this via the smoke >>> tester, I suppose? >>> >>> ~ David Smiley >>> Apache Lucene/Solr Search Developer >>> http://www.linkedin.com/in/davidwsmiley >>> >>> >>> On Wed, Apr 13, 2022 at 5:59 PM Anshum Gupta <[email protected]> >>> wrote: >>> >>>> Thanks for the update, Houston. >>>> >>>> I think this calls for an RC4. >>>> >>>> I'll be happy to review the PRs as they come in. >>>> >>>> On Wed, Apr 13, 2022 at 2:32 PM Houston Putman <[email protected]> >>>> wrote: >>>> >>>>> Hello everyone, >>>>> >>>>> Unfortunately, while the build passed I noticed some issues when >>>>> building the remaining infrastructure to finish the release process (A >>>>> fair >>>>> amount of stuff left to do since the docker and gradle migration). >>>>> >>>>> The biggest issue I found was that the solr-core maven artifact cannot >>>>> be used, since it still relies on the solr-server artifact, which doesn't >>>>> exist. There are also modules that don't have maven artifacts created. >>>>> (And >>>>> module artifacts rely on solr-core, so they also cannot be used) >>>>> >>>>> I think this warrants an RC4 (and while we do have the RC3 release >>>>> artifacts in https://dist.apache.org/repos/dist/release/solr/solr/), >>>>> we can work with Apache infra to get that removed. >>>>> >>>>> If y'all think we should continue with the release anyways, I can do >>>>> that as well. Will wait for some consensus while continuing to build in >>>>> the >>>>> necessary release steps. (for RC3 or RC4) >>>>> >>>>> Will have a fair number of PRs coming up to fix these things, so help >>>>> reviewing them would be much appreciated. >>>>> >>>>> - Houston >>>>> >>>>> On Fri, Apr 8, 2022 at 6:55 PM Jan Høydahl <[email protected]> >>>>> wrote: >>>>> >>>>>> It's been >72h since the vote was initiated and the result is: >>>>>> >>>>>> +1 7 (7 binding) >>>>>> 0 1 >>>>>> -1 0 >>>>>> >>>>>> This vote has PASSED >>>>>> >>>>>> Congratulations everyone for reaching this milestone! >>>>>> >>>>>> There are still a few loose ends before the release can be published >>>>>> and announced. >>>>>> I'm away the next week, and Houston Putman has agreed to take over >>>>>> the RM job from here. >>>>>> >>>>>> Thanks for stepping up Houston! >>>>>> >>>>>> Jan >>>>>> >>>>>> 8. apr. 2022 kl. 23:43 skrev Mike Drob <[email protected]>: >>>>>> >>>>>> If we're not doing anything with the release artifacts anyway (since >>>>>> you'll be on holiday, Jan), would it be fine to leave it open over the >>>>>> weekend? I didn't get nearly the amount of testing done on this that I >>>>>> wanted to, mainly trying to figure out if SOLR-16143 was a real problem >>>>>> (yes) or just a test issue (no) or worthy of blocking a release (probably >>>>>> not). >>>>>> >>>>>> On Fri, Apr 8, 2022 at 4:40 PM Anshum Gupta <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> and just around the deadline, I got the smoke-tester to pass. Thanks >>>>>>> to everyone who helped :) >>>>>>> >>>>>>> I changed a ton of things but most likely, it was an init.gradle >>>>>>> file with some random stuff that was causing the issue. I remember >>>>>>> having >>>>>>> deleted that file a few months ago, but not sure what job regenerates >>>>>>> that >>>>>>> and adds that to the ~/.gradle folder. >>>>>>> >>>>>>> Here's my +1 (binding) >>>>>>> SUCCESS! [0:46:31.241458] >>>>>>> >>>>>>> Also, tested SolrJ and some basic search/indexing using some sample >>>>>>> app. >>>>>>> >>>>>>> >>>>>>> On Fri, Apr 8, 2022 at 1:06 PM Jan Høydahl <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> This vote ends in an hour or so. >>>>>>>> While there are currently five +1's and a few +0, I feel it is >>>>>>>> inconclusive due to the SolrCell issue? >>>>>>>> Kevin, guess your vote will decide :) >>>>>>>> >>>>>>>> Jan >>>>>>>> >>>>>>>> 8. apr. 2022 kl. 18:00 skrev Kevin Risden <[email protected]>: >>>>>>>> >>>>>>>> The smoke tester passed for me: SUCCESS! [0:54:21.639508] >>>>>>>> >>>>>>>> However, I'm running into issues checking Tika integration / Solr >>>>>>>> Cell. Following >>>>>>>> https://nightlies.apache.org/solr/draft-guides/solr-reference-guide-nightly/solr/9_0/indexing-guide/indexing-with-tika.html >>>>>>>> >>>>>>>> 2022-04-08 14:52:18.768 ERROR (qtp201274566-26) [] >>>>>>>>> o.a.s.s.SolrRequestParsers Couldn't get multipart parts in order to >>>>>>>>> delete >>>>>>>>> them => java.lang.IllegalStateException: No multipart config for >>>>>>>>> servlet >>>>>>>>> at org.eclipse.jetty.server.Request.getParts(Request.java:2420) >>>>>>>>> java.lang.IllegalStateException: No multipart config for servlet >>>>>>>> >>>>>>>> >>>>>>>> I tried curl and the bin/post examples and they didn't work. I also >>>>>>>> tried running Solr with "./bin/solr -e schemaless >>>>>>>> -Dsolr.module=extraction" >>>>>>>> but the behavior was the same. >>>>>>>> >>>>>>>> This happened to be the first module I started trying to make sure >>>>>>>> I didn't break anything with tons of the module changes in 9.0. I know >>>>>>>> SQL >>>>>>>> issues were fixed. >>>>>>>> >>>>>>>> Anshum - I can try to help debug the security manager stuff on the >>>>>>>> ticket you filed https://issues.apache.org/jira/browse/SOLR-16135 >>>>>>>> >>>>>>>> Kevin Risden >>>>>>>> >>>>>>>> Kevin Risden >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Apr 7, 2022 at 5:28 PM Anshum Gupta <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> I can't seem to get the smoketest to pass on this RC, like the >>>>>>>>> previous two. >>>>>>>>> >>>>>>>>> At this point, I've tried: >>>>>>>>> - Fresh clone of the repository >>>>>>>>> - Multiple JDK versions from JDK11, 14, 17 >>>>>>>>> - Cleanup gradle cache >>>>>>>>> - Multiple machines (Macbook and iMac) >>>>>>>>> >>>>>>>>> At this point I have the HDFS module tests and the adminUI test >>>>>>>>> failing with SecurityManager related exceptions e.g. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *org.apache.solr.hdfs.store.HdfsDirectoryTest > classMethod >>>>>>>>> FAILED java.security.AccessControlException: access denied >>>>>>>>> ("java.io.FilePermission" >>>>>>>>> "/Users/anshumg/workspace/apache/solr/solr/modules/hdfs/build/tmp" >>>>>>>>> "write")* >>>>>>>>> >>>>>>>>> I don't have a custom security policy and even running with >>>>>>>>> *-Djava.security.debug=access,failure,policy >>>>>>>>> *didn't get any useful information. >>>>>>>>> >>>>>>>>> I'll continue looking into it, but if I don't get anywhere, I'll >>>>>>>>> vote based on my custom tests and manual testing. >>>>>>>>> >>>>>>>>> -Anshum >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Apr 5, 2022 at 2:58 PM Jan Høydahl <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Please vote for release candidate 3 for Solr 9.0.0 >>>>>>>>>> >>>>>>>>>> The artifacts can be downloaded from: >>>>>>>>>> >>>>>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC3-rev-e9e64f83a8c972b5a3f3460899c81ee9ccde2d1e >>>>>>>>>> >>>>>>>>>> You can run the smoke tester directly with this command: >>>>>>>>>> >>>>>>>>>> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>>>>>>>> >>>>>>>>>> https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC3-rev-e9e64f83a8c972b5a3f3460899c81ee9ccde2d1e >>>>>>>>>> >>>>>>>>>> You are encouraged to do an extra thorough test and manual >>>>>>>>>> inspection beyond >>>>>>>>>> running the smoketester, since this is a major release. >>>>>>>>>> >>>>>>>>>> You can build a release-candidate of the official docker image >>>>>>>>>> using the following command: >>>>>>>>>> >>>>>>>>>> DIST_BASE=https://dist.apache.org/repos/dist/dev/solr && \ >>>>>>>>>> >>>>>>>>>> RC_FOLDER=solr-9.0.0-RC3-rev-e9e64f83a8c972b5a3f3460899c81ee9ccde2d1e >>>>>>>>>> && \ >>>>>>>>>> docker build >>>>>>>>>> $DIST_BASE/$RC_FOLDER/solr/docker/Dockerfile.official \ >>>>>>>>>> --build-arg >>>>>>>>>> SOLR_DOWNLOAD_URL=$DIST_BASE/$RC_FOLDER/solr/solr-9.0.0.tgz \ >>>>>>>>>> -t solr-rc:9.0.0-3 >>>>>>>>>> >>>>>>>>>> The vote will be open for at least 72 hours i.e. until 2022-04-08 >>>>>>>>>> 22:00 UTC. >>>>>>>>>> >>>>>>>>>> [ ] +1 approve >>>>>>>>>> [ ] +0 no opinion >>>>>>>>>> [ ] -1 disapprove (and reason why) >>>>>>>>>> >>>>>>>>>> Here is my +1 >>>>>>>>>> >>>>>>>>>> SUCCESS! [0:46:42.638796] >>>>>>>>>> >>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Anshum Gupta >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Anshum Gupta >>>>>>> >>>>>> >>>>>> >>>> >>>> -- >>>> Anshum Gupta >>>> >>> -- Anshum Gupta
