Ok false alarm I think missed updating the separate solr-test-framework line in my build (need to parameterize that version or something), I have other problems with the upgrade now such as import org.apache.lucene.util.QuickPatchThreadsFilter going away, but the class def problem disappeared
On Thu, Jan 12, 2023 at 8:47 PM Gus Heck <gus.h...@gmail.com> wrote: > I might be finding something. I just tried upgrading JesterJ to 9.1 from > 9.0 and got > > org/apache/lucene/codecs/lucene90/Lucene90Codec > java.lang.NoClassDefFoundError: > org/apache/lucene/codecs/lucene90/Lucene90Codec > at org.apache.lucene.util.LuceneTestCase.<clinit>(LuceneTestCase.java:663) > at java.base/java.lang.Class.forName0(Native Method) > at java.base/java.lang.Class.forName(Class.java:398) > at > com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:627) > Caused by: java.lang.ClassNotFoundException: > org.apache.lucene.codecs.lucene90.Lucene90Codec > at > java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) > at > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) > ... 4 more > > It looks like we upgraded lucene to 9.3 and not the lucene-test-framework > (still 9.0)... (still looking into this) > > On Tue, Jan 10, 2023 at 3:56 PM Ishan Chattopadhyaya < > ichattopadhy...@gmail.com> wrote: > >> You're good to go, Michael. Wish you all the best! >> >> On Wed, Jan 11, 2023 at 1:28 AM Michael Gibney >> <mich...@michaelgibney.net> wrote: >> > >> > Great, thanks Alessandro! Once I get the go-ahead from Ishan that he's >> > done wrapping up the loose ends from the 9.1.0 release, I'll build an >> > RC based on 2c669fe43777342758a0042b821efb6aa3ec15b6. >> > >> > Michael >> > >> > On Tue, Jan 10, 2023 at 12:47 PM Alessandro Benedetti >> > <a.benede...@sease.io> wrote: >> > > >> > > From my side I merged everything and I am monitoring Jenkins! >> > > >> > > >> > > On Mon, 9 Jan 2023, 10:08 Alessandro Benedetti, <a.benede...@sease.io >> > >> > > wrote: >> > > >> > > > Hi Michael, yes! Doing it right now! >> > > > >> > > > Cheers >> > > > -------------------------- >> > > > *Alessandro Benedetti* >> > > > Director @ Sease Ltd. >> > > > *Apache Lucene/Solr Committer* >> > > > *Apache Solr PMC Member* >> > > > >> > > > e-mail: a.benede...@sease.io >> > > > >> > > > >> > > > *Sease* - Information Retrieval Applied >> > > > Consulting | Training | Open Source >> > > > >> > > > Website: Sease.io <http://sease.io/> >> > > > LinkedIn <https://linkedin.com/company/sease-ltd> | Twitter >> > > > <https://twitter.com/seaseltd> | Youtube >> > > > <https://www.youtube.com/channel/UCDx86ZKLYNpI3gzMercM7BQ> | Github >> > > > <https://github.com/seaseltd> >> > > > >> > > > >> > > > On Fri, 6 Jan 2023 at 17:18, Michael Gibney < >> mich...@michaelgibney.net> >> > > > wrote: >> > > > >> > > >> Alessandro, are you still looking to include the SOLR-16588 bugfix? >> > > >> Ishan, any updates on the handful of tasks that you had mentioned >> were >> > > >> still outstanding from the 9.1.0 release? Aside from these two open >> > > >> questions, it looks like branch_9_1 has settled down with all of >> the >> > > >> changes we had discussed for inclusion in 9.1.1 (unless I'm missing >> > > >> something). >> > > >> Michael >> > > >> >> > > >> On Thu, Jan 5, 2023 at 4:50 PM Alessandro Benedetti >> > > >> <a.benede...@sease.io> wrote: >> > > >> > >> > > >> > discussing on the PR, once clarified a bit around Lucene94 (and a >> > > >> backport >> > > >> > to Lucene 9.3 ad hoc for 9.1.1) we should be ready to merge and >> cherry >> > > >> pick! >> > > >> > >> > > >> > -------------------------- >> > > >> > *Alessandro Benedetti* >> > > >> > Director @ Sease Ltd. >> > > >> > *Apache Lucene/Solr Committer* >> > > >> > *Apache Solr PMC Member* >> > > >> > >> > > >> > e-mail: a.benede...@sease.io >> > > >> > >> > > >> > >> > > >> > *Sease* - Information Retrieval Applied >> > > >> > Consulting | Training | Open Source >> > > >> > >> > > >> > Website: Sease.io <http://sease.io/> >> > > >> > LinkedIn <https://linkedin.com/company/sease-ltd> | Twitter >> > > >> > <https://twitter.com/seaseltd> | Youtube >> > > >> > <https://www.youtube.com/channel/UCDx86ZKLYNpI3gzMercM7BQ> | >> Github >> > > >> > <https://github.com/seaseltd> >> > > >> > >> > > >> > >> > > >> > On Wed, 4 Jan 2023 at 23:26, Michael Gibney < >> mich...@michaelgibney.net> >> > > >> > wrote: >> > > >> > >> > > >> > > This seems fine to me, assuming no objections from others. >> > > >> > > >> > > >> > > On Wed, Jan 4, 2023 at 4:30 PM Alessandro Benedetti >> > > >> > > <a.benede...@sease.io> wrote: >> > > >> > > > >> > > >> > > > What about including this as well in 9.1.1 : >> > > >> > > > https://github.com/apache/solr/pull/1255 ? >> > > >> > > > It's an annoying neural search bug, and it's pretty much >> done, just >> > > >> > > waiting >> > > >> > > > for a few checks and then I'll merge it with the changes! >> > > >> > > > -------------------------- >> > > >> > > > *Alessandro Benedetti* >> > > >> > > > Director @ Sease Ltd. >> > > >> > > > *Apache Lucene/Solr Committer* >> > > >> > > > *Apache Solr PMC Member* >> > > >> > > > >> > > >> > > > e-mail: a.benede...@sease.io >> > > >> > > > >> > > >> > > > >> > > >> > > > *Sease* - Information Retrieval Applied >> > > >> > > > Consulting | Training | Open Source >> > > >> > > > >> > > >> > > > Website: Sease.io <http://sease.io/> >> > > >> > > > LinkedIn <https://linkedin.com/company/sease-ltd> | Twitter >> > > >> > > > <https://twitter.com/seaseltd> | Youtube >> > > >> > > > <https://www.youtube.com/channel/UCDx86ZKLYNpI3gzMercM7BQ> >> | Github >> > > >> > > > <https://github.com/seaseltd> >> > > >> > > > >> > > >> > > > >> > > >> > > > On Tue, 3 Jan 2023 at 17:18, Shawn Heisey < >> apa...@elyograg.org> >> > > >> wrote: >> > > >> > > > >> > > >> > > > > On 1/3/23 08:05, Michael Gibney wrote: >> > > >> > > > > > and possibly upgrade to Lucene 9.4 >> > > >> > > > > > https://issues.apache.org/jira/browse/SOLR-16442 >> > > >> > > > > > particularly considering: >> > > >> > > > > > https://github.com/apache/lucene/pull/11718 >> > > >> > > > > >> > > >> > > > > It seems like a bad idea to upgrade a critical component >> to a new >> > > >> major >> > > >> > > > > or minor version in a bugfix release, unless that upgrade >> closes a >> > > >> > > > > security vulnerability and is fairly limited in scope. I >> don't >> > > >> think >> > > >> > > > > either of those applies. >> > > >> > > > > >> > > >> > > > > Solr 9.1.0 includes Lucene 9.3.0. There are no further >> 9.3.x >> > > >> releases, >> > > >> > > > > so we don't have that as an option. >> > > >> > > > > >> > > >> > > > > > The main concerns for all the above are classloading >> issues. The >> > > >> > > first >> > > >> > > > > > one (SlotAcc) I think should be backported, since we >> know it has >> > > >> > > > > > manifested in the wild and it's a very self-contained >> fix. >> > > >> > > > > >> > > >> > > > > My bias would be to NOT upgrade Lucene, for reasons >> described >> > > >> above. >> > > >> > > > > The change on SOLR-16165 looks OK to me for a point >> release. >> > > >> > > > > >> > > >> > > > > Thanks, >> > > >> > > > > Shawn >> > > >> > > > > >> > > >> > > > > >> > > >> >> --------------------------------------------------------------------- >> > > >> > > > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> > > >> > > > > For additional commands, e-mail: dev-h...@solr.apache.org >> > > >> > > > > >> > > >> > > > > >> > > >> > > >> > > >> > > >> --------------------------------------------------------------------- >> > > >> > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> > > >> > > For additional commands, e-mail: dev-h...@solr.apache.org >> > > >> > > >> > > >> > > >> > > >> >> > > >> >> --------------------------------------------------------------------- >> > > >> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> > > >> For additional commands, e-mail: dev-h...@solr.apache.org >> > > >> >> > > >> >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> > For additional commands, e-mail: dev-h...@solr.apache.org >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >> For additional commands, e-mail: dev-h...@solr.apache.org >> >> > > -- > http://www.needhamsoftware.com (work) > http://www.the111shift.com (play) > -- http://www.needhamsoftware.com (work) http://www.the111shift.com (play)
