If it's non-trivial and you're super confident, commit directly.
Otherwise, throw up a PR (or patch) immediately.

I looked at your patch here.  +1 from me.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley


On Tue, May 2, 2023 at 2:01 PM Eric Pugh <ep...@opensourceconnections.com>
wrote:

> What is the best way to fix this?  I went into branch_9x and checked, and
> yeah, I totally goofed it somehow…..
>
> Can I commit the attached patch directly to branch_9x?
>
>
>
> On May 2, 2023, at 3:53 AM, Jan Høydahl <jan....@cominvent.com> wrote:
>
> Last successful jenkins "check" on branch_9x was 26 days ago:
> https://ci-builds.apache.org/job/Solr/job/Solr-Check-9.x/
>
> Errors like this
>
> 1. ERROR in 
> /tmp/src/solr/solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java
>  (at line 119)
>       this.pollQueueTimeMillis = builder.pollQueueTime;
>            ^^^^^^^^^^^^^^^^^^^
> pollQueueTimeMillis cannot be resolved or is not a field
>
> https://ci-builds.apache.org/job/Solr/job/Solr-Check-9.x/lastBuild/console
>
> I think perhaps backport of
> https://issues.apache.org/jira/browse/SOLR-13605 was the cause?
>
> Jan
>
>
> _______________________
> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467
> | http://www.opensourceconnections.com | My Free/Busy
> <http://tinyurl.com/eric-cal>
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
> This e-mail and all contents, including attachments, is considered to be
> Company Confidential unless explicitly stated otherwise, regardless
> of whether attachments are marked as such.
>
>

Reply via email to