Hi Gus, thanks for the feedback! I traced the source of the commit to this:
PR: https://github.com/apache/lucene-solr/pull/994 JIRA: https://issues.apache.org/jira/browse/SOLR-13662 where, from the outside, it looks like the regex just happened to be what was written; I couldn't find any specific discussion around what should/shouldn't be validated, so I don't think the difference in regexes that exists now was intentional for any reason. Given that, the change I'd suggest making is something like either of these: a) https://github.com/apache/solr/commit/638fd768ebd7ed7908029ced08e56bed05a4a2a5 b) https://github.com/apache/solr/commit/998fffdccf51a0560589e2cb413e9da127a5f26e I expect the potential risks of tweaking the validation are fairly minor, especially if any fix is purely additive to allow more valid options (which has presumably passed validation at time of creation), but I haven't confirmed that to 100% confidence yet. (It certainly doesn't help that running the tests occasionally crashes my machine - anyone out there on Manjaro Talos 22.1.2, please let me know if you have any tips on running the test suite without issue) I misread your comment and opened SOLR-16820 a bit prematurely - sorry! - but I'll keep the conversation here until it's time to move towards the JIRA ticket. Cheers, Will
