I’ve been learning a lot more about our BATS tests, and they are pretty straightforward way to write an integration tests.
Right now we have a pretty minimal one https://github.com/apache/solr/blob/main/solr/packaging/test/test_packages.bats You can run in via ./gradlew integrationTests --tests test_packages.bats I think that you could write a test the demonstatraes the fix by copying from https://github.com/apache/solr/blob/main/solr/packaging/test/test_create_collection.bats and then adding it to test_packages.bats. > On Jun 4, 2023, at 10:06 AM, Will White <willdotwhit...@gmail.com> wrote: > > Thanks again for your input so far! Sorry for the delay, it's been a busy > week. > > I've put together a draft PR here: https://github.com/apache/solr/pull/1688 > > I'm not at all sure how to approach automated tests/verification for this > PR, I can't see an obvious place to add unit tests - I'm torn between > "directly testing my change is a bit too small scale" and "testing the next > level up might be wildly more work than I'm prepared for", could someone > please be able to point me in the right direction, is there a standard > approach I should take? > > Cheers, > > Will _______________________ Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
