The idea is that jenkins runs it after the builds to figure out if
something changed in the working copy. At ANT times this was implemented
exactly like this, we failed build on Jenkins when the working copy
changed. This was especially important before we used SecurityManager to
prevent tests writing outside their temporary dirs. We had tests
touching files in working copy.
We had a discussion about this task with Dawid Weiss when changing to
Gradle, but I don't remeber the outcome. To me the default should be
false. I think Dawid argued that the check is good to notify the
committer that there may be uncommitted changes, but I doubt this helps.
A warning would be fine.
Uwe
Am 06.09.2023 um 18:43 schrieb David Smiley:
Our build, inherited from Lucene, contains a custom validation check
"checkWorkingCopyClean" which can be disabled with
"validation.git.failOnModified=false" in your gradle.properties. I always
set this; the concept of failOnModifies seems dubious to me; it annoys me.
Can an advocate of this setting speak up and tell me why it's useful?
~ David
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: u...@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org
