On 9/6/23 10:43, David Smiley wrote:
Our build, inherited from Lucene, contains a custom validation check
"checkWorkingCopyClean" which can be disabled with
"validation.git.failOnModified=false" in your gradle.properties.  I always
set this; the concept of failOnModifies seems dubious to me; it annoys me.
Can an advocate of this setting speak up and tell me why it's useful?

I get hit by that pretty much every time I run the check target. I don't think it fills any useful role ... 99 percent of the time the check target is executed, I am pretty sure that the checkout won't be clean. I wouldn't mind a warning logged at the end of the run that says the working tree isn't clean, but I really hate that it makes the check fail.

Thanks,
Shawn


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org

Reply via email to