>>> move check_tick plugin call to bottom of priority loop, clean up some >>> whitespace/comments
>> Why? What's the effect on performance and otherwise? Theo Van Dinter <[EMAIL PROTECTED]> writes: > This is related to my wanting to make shortcut (aka early exit) a > plugin, but ignoring that... There is no performance change, and it > lets the plugins be called at the end of the loop, not in the middle > so the plugin is actually useful for "end of priority loop" > operations. Doing early exit via a plugin is not the right way. The Scan module should be subclassed with multiple scanning techniques which define their own check() function. And, yes, that is about both performance and flexibility. I'm nearly certain the check_tick API is not the right way. > On an aside, not everything in 3.1 is going to be about performance, and we > don't need to justify every little change (this was a very little change). There was no reason given for the change and no bug number, I just wanted to know why the change was made since the log message didn't say. Daniel -- Daniel Quinlan ApacheCon! 13-17 November (3 SpamAssassin http://www.pathname.com/~quinlan/ http://www.apachecon.com/ sessions & more)
