On Mon, Sep 27, 2004 at 11:25:12AM -0700, Dan Quinlan wrote: > Doing early exit via a plugin is not the right way. The Scan module > should be subclassed with multiple scanning techniques which define > their own check() function. And, yes, that is about both performance > and flexibility. I'm nearly certain the check_tick API is not the right > way.
Yeah, we discussed this over breakfast -- I'm not 100% on using check_tick, but it makes the most sense given the current code: it allows users to enable/disable early exit by loading or not loading the plugin, and the sum change to the core SA code is only a few lines (look for a "early exit?" flag and break out of the priority loop, skip AWL, etc.) There are better ways to do it, some of which we discussed, but requires a lot of redesign of the code, which is fine if we want to do that. Anyway, I'm planning to write up my general thoughts about early exit, and we all can come up with a general plan and design specs. I haven't actively started down a path, so it's not like there's been any wasted effort on this yet. My stuff is mostly random thoughts and scribbles in my notebook right now. -- Randomly Generated Tagline: "For a while, all that stood between America and annihilation was a man with a drinking problem." - Some program on the Learning Channel
pgpOVRxx4aU1y.pgp
Description: PGP signature
