http://bugzilla.spamassassin.org/show_bug.cgi?id=3825
------- Additional Comments From [EMAIL PROTECTED] 2004-09-27 15:45 -------
Subject: Re: Unescaped '#' in rawbody causes havoc
On Mon, Sep 27, 2004 at 03:23:57PM -0700, [EMAIL PROTECTED] wrote:
> which is what borks it all up. I'm looking into it.
Ha! It looks like bad documentation. # needs explicit escaping according to
the code in Conf/Parser:
$line =~ s/(?<!\\)#.*$//; # remove comments
that's right at the very top of the conf parser (it's the very first
command executed in the parse loop actually), so the RE gets mangled
when it's read in, and that propagates down through everything else.
So I think we need to document that the RE needs # escaped, or we need
a better way of killing comments. IMO, the # escaping seems like the
better (easier too) choice.
For killing comments, we could just say that comments in the lines themselves
are invalid and then just trim out:
s/^\s*#.*$//;
The only place we use comments in-line seems to be "endif # some::plugin",
which I think it bad formatting anyway, but...
But since all the standard rules escape # already, documentating it seems like
the better choice.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
