-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Daniel Quinlan writes: > Justin Mason <[EMAIL PROTECTED]> writes: > > > That would be a major change in how our configuration files are parsed, > > breaking a documented (although not particularly clearly) convention > > that's been there since the project began. It's also inconsistent with > > the convention for this configuration file format. > > It would be better if our parser detected invalid lines rather than > outputting perl errors due to us parsing garbage. That's my main > concern. I am actually fine with requiring # to be escaped. My main > concern is the non-clarity of the error statements, documentation does > not fix that. ah, gotcha. sorry, I'm a bit tired today so comprehension's not quite at full speed. (just back from Toorcon.) > (Side note: although not a requirement for this, getting rid of EOL > comments would make this easier if it was coupled with a requirement > that # be escaped.) y'see , I think that's the red herring -- there are many other ways to screw up the syntax of rules, e.g. rawbody HAS_RED_BODY_BG /body bgcolor=["']/fffff/i would similarly produce horrible perlish syntax errors, and there's no hashes involved there at all. BTW if you can wait a little bit, I have a patch from McAfee's tree that does this nicely if I recall correctly -- it catches compile-time errors in the rules and outputs a decent error message warning of a syntax error in that rule, by name. ;) - --j. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Exmh CVS iD8DBQFBWKJHQTcbUG5Y7woRAphnAJ4pb0SyEJqrGSCMg20L/LNZQ8o8cACg3R0E 626z2cpHF+QO6m8JQxpdSl0= =VgYh -----END PGP SIGNATURE-----
