http://bugzilla.spamassassin.org/show_bug.cgi?id=4010





------- Additional Comments From [EMAIL PROTECTED]  2004-12-04 12:24 -------
The code in question is this: 
 
# always copy the config, later code may disable 
my $copy_config_p = 1; 
#[...] 
if ( defined $opt{'max-conn-per-child'} ) { 
  $clients_per_child = $opt{'max-conn-per-child'}; 
  # Make sure that the values are at least 1 
  $clients_per_child = undef if ( $clients_per_child < 1 ); 
} 
# Set some "sane" limits for defaults 
$childlimit        ||= 5; 
$clients_per_child ||= 200; 
#[...] 
unless ($clients_per_child > 1) { 
  # unset $copy_config_p so we don't bother trying to copy things back 
  # after closing the connection 
  $copy_config_p = 0; 
} 
#[...] 
# If we need Storable, and it's not installed, alert now before we daemonize. 
die "Required module Storable not found!\n" 
  if ($copy_config_p && !$spamtest->_is_storable_available()); 
 
 
So we do indeed require Storable as long as --max-conn-per-child is not 1.  So 
which is the way to fix this: 
(a) Always use --max-conn-per-child=1 in the tests (which might miss bugs) 
(b) Make $copy_config_p aware of the --no-user-config switch and use that in 
the tests. 
(c) Both. 
 
I guess (b) is the correct answer. 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to