http://bugzilla.spamassassin.org/show_bug.cgi?id=4010
------- Additional Comments From [EMAIL PROTECTED] 2004-12-04 16:04 ------- Subject: Re: make test fails if Storable is not present On Sat, Dec 04, 2004 at 01:46:36PM -0800, [EMAIL PROTECTED] wrote: > > On Sat, Dec 04, 2004 at 12:24:37PM -0800, [EMAIL PROTECTED] wrote: > > So we do indeed require Storable as long as --max-conn-per-child is not 1. > > So > > which is the way to fix this: > > (a) Always use --max-conn-per-child=1 in the tests (which might miss bugs) > > (b) Make $copy_config_p aware of the --no-user-config switch and use that > > in > > the tests. > > (c) Both. > > > > I guess (b) is the correct answer. > > I seem to recall that we simplified things down to "always copy" from some > bug... aha, bug 3826 is referenced by r55242 which is the commit that set it > up that way. > Indeed, --no-user-config is set when using SQL prefs, so what it really means is not NO user config, but NO ON DISK (ie user_prefs) user config. So (b) is not a valid option. > I would add a (d) option: > > (d) If Storable is available, run test as normal. If not, run with > --max-conn-per-child=1. Perhaps put a notice when doing the "perl > Makefile.PL" that indicates some functionality may not be tested. > This sounds like the least painful route. Michael ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
