http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
------- Additional Comments From [EMAIL PROTECTED] 2005-05-05 18:30 ------- Looking at what would be involved, I think that making conf a class variable is way too big a change for little benefit. Mail::SpamAssassin is used as a factory. There should be a singleton instance of it, and new() should be the only class method it has. What is wrong with what we have now is that Mail::SpamAssassin->parse is being used as a class method in three places. It should always be called as an instance method, then the problem goes away. This requires no change to the parse() API. Since parse is defined in Mail::SpamAssassin, there is no need to pass a main object in to the call. sa-learn already creates a Mail::SpamAssassin instance, we just have to use it in the first call to parse. Conceptually, this is the right thing. It is saying that the parwse method can be influenced by the SpamAssassin configuration options. That is more correct than saying that parse does something that cannot be modified by any options settings. I'll see if I can modify the patch to do this. ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
