http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
------- Additional Comments From [EMAIL PROTECTED] 2005-05-05 20:31 ------- Theo, There's a lot of stuff in the comments here. I want to make sure that your vote is about what ended in the patch and not about things I only talked about doing. The way it ended up the changes are: 1) Mail::SpamAssassin->parse() was called in three places as a class method, even though the POD doesn't document it as being one. That happened not to break anything before now, but should be fixed independent of this bug. It's a one line change in two of those places, and a three line change in the third. The API for parse() does not have to be changed. 2) The Mail::SpamAssassin instance is passed in to the constructors for Message, Node, and HTML so they can have access to configuration options. That adds an argument to the constructor, a 'main' instance variable that is assigned in the constructor and deleted in the finish() method. 3) The code that actually performs the enhancement. #1 should be done anyway. #3 is not the issue you are bringing up. I don't know that #2 is a big change to the core API. The three constructors are only called in a handful of places in all. It could be argued that we should not have core functionality like message parsing and HTML rendering that cannot be modified by any configuration options. A plugin wouldn't help. Right now there is no way for the HTML rendering to make use of anything in conf, for this enhancement or for any future one that has to do with HTML. ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
