http://bugzilla.spamassassin.org/show_bug.cgi?id=4153
------- Additional Comments From [EMAIL PROTECTED] 2005-05-21 08:08 -------
Subject: Re: [review] RFE : Spamc patch for config file
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I think things are going in two different paths, closely related, but
still different.
Let me make restate how I believe things should work.
Unless a specific define as been set at compile time, spamc will never
attempt to stat a config file, unless that config file was passed to it
via -F <somefile>.
If so desired, the person who compiles spamc can set the define that
will a) cause it to stat a single file in the system config directory
(what the current proposed patch now allows for), or b) go search
through several directories to find a config file (what the current code
in trunk allows for), or c) use whatever was passed in via -F <somefile>.
My thinking is, why take the stat overhead if it's never going to be
used? It should be easy enough to provide that functionality to a local
admin if they so desire, I see the usefulness of allowing a config file
in multiple places but its overhead is too great IMHO.
I'll backtrack a little with the following thought, this does create a
situation where one spamc will behave differently from another spamc,
will this cause support nightmares? How do you tell how a particular
spamc was built? Maybe -V should print out the compile time information
(see mutt -v) as an example.
BTW, for those wanting to run a benchmark, here is the benchmark code:
#!/usr/bin/perl -w
use strict;
use Benchmark qw(:all);
timethese(10000, {
'spamc.old' => '`/usr/bin/spamc.old < /dev/null`',
'spamc.new' => '`/usr/bin/spamc < /dev/null`',
});
spamc.old was just copied over from spamc and the new version was
installed in place.
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCj07gG4km+uS4gOIRAgcxAJwKgSqS88lksZz5gdkDs8iMUKzhsgCfbFP0
CezZWdQ+vjA5n2E5zSYDTSc=
=dZ+E
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
