http://bugzilla.spamassassin.org/show_bug.cgi?id=4412
------- Additional Comments From [EMAIL PROTECTED] 2005-08-17 15:51 -------
I'm glad we can get away with code that is so much simpler than what Net::DNS
has to do.
I see that my $data = $pkt->data; still seems to be unnecessary, with $data
never being referenced. Can it be removed as part of the patch?
I have a question about something I noticed while checking over the code for the
patch which exceeds my knowledge of perl. In sub connect_sock there is a line
$self->{sock}->close() if $self->{sock};
In sub finish_socket I see
if ($self->{sock}) {
$self->{sock}->close();
delete $self->{sock};
}
Is the delete necessary in connect_sock too? Should connect_sock just call
finish_socket there instead of {sock}->close?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
