http://issues.apache.org/SpamAssassin/show_bug.cgi?id=3109
------- Additional Comments From [EMAIL PROTECTED] 2006-04-04 11:28 ------- Dude, you didn't "request time to review" -- you "suggested" that people should "exercise caution and review time". It was not clear that *you* were the person you wanted to exercise that review time! ;) Also your first comment was 2 weeks after the patch was posted, saying "I'm not vetoing the patch but am a little concerned". So I took that as not indicating a whole lot of worry. > This is "ONE" implementation of shortcircuit, and from the comments, not even > the best, and happens to stomp on at least one other known implementation. hmm -- where is this other known implementation? Is it open source, available for use in Apache SpamAssassin right now? Is it ready to apply to SVN trunk? Does it implement techniques we've been agreeing on for two years, as this does? If this other code needs to be taken into account, it should be made part of the open source codebase so it is at least visible, and efforts be made to get it into SVN, as Dallas is doing here. It is nice to support proprietary work in Apache SpamAssassin, but not to the detriment of the open-source product's quality. > This code should be backed out and when we get the Check plugin code in place > you can then put it all in your own plugin to avoid creating problems for > other people's code. I strongly disagree that we should make this work conditional on the Check plugin. Do it the other way around -- when the Check plugin is completed, *then* rearrange the contents of svn trunk to work with it, not vice versa. We cannot freeze the entire contents of the PerMsgStatus class pending a Check plugin, given that the last comment on bug 4776, was *2 months ago*, and there's still some serious disagreement there. Fundamentally it makes no sense to block the rest of the project based on a task that does not seem to be going forward! ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
