http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4952
------- Additional Comments From [EMAIL PROTECTED] 2006-08-12 16:29 -------
(In reply to comment #9)
> ok, I've come around to it ;)
:)
> +0.9. there is still an issue, with:
>
> +=item PREFIX
> +
> +Used as the root for certain directory paths such as:
> +
> + '__prefix__/etc/mail/spamassassin'
> + '__prefix__/etc/spamassassin'
> +
> +Defaults to "/usr/local".
>
> this is misleading -- nobody (except for the odd BSD person ;) will
> have encountered /usr/local/etc/spamassassin. a better example
> would be the entry from @default_rules_path:
I don't understand how this is misleading. Just because most people don't have
that directory doesn't mean that we don't look for it, first on the list
actually:
@site_rules_path = (
'__local_rules_dir__',
'__prefix__/etc/mail/spamassassin',
'__prefix__/etc/spamassassin',
'/usr/local/etc/spamassassin',
'/usr/pkg/etc/spamassassin',
'/usr/etc/spamassassin',
'/etc/mail/spamassassin',
'/etc/spamassassin',
);
> +=item PREFIX
> +
> +Used as the root for certain directory paths such as:
> +
> + '__prefix__/share/spamassassin'
> +
> +Defaults to "/usr/local".
>
> a little nitpicky, sorry. I'm striving for perfection -- in your code ;)
we can change it if you really think it's an issue, but I don't think most
people have encountered /usr/local/share/spamassassin either.
However, I came up with my own -1 on my patch. ;)
Adding in __local_state_dir__ by itself means that in a standard installation:
/var/lib/spamassassin/3.002000
/var/lib
/usr/share/spamassassin
which is obviously bad. So I'm not sure how to address #4 in my list, which
kind of sucks. There are two things that I can think of immediately. 1) We
change how local_state_dir is defined by default to be <whatever>/spamassassin.
Alternately, the original list for rules files was:
'__local_state_dir__/spamassassin/__version__',
'__def_rules_dir__',
So we could document that people can pass in a different DEF_RULES_DIR, and then
things will work as expected. It's a bit confusing though.
I think I'll go with the first one, patch in a minute. (patches while you
wait?)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
