https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5931
Mark Martinec <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 votes
--- Comment #3 from Mark Martinec <[EMAIL PROTECTED]> 2008-10-16 08:13:49 PST
---
Henrik Krohns wrote:
> I don't really care if there are duplicates, since it doesn't affect anything.
> Probably only if you use exclusions. In that case the code should use two
> separate arrays for includes and excludes, instead of one unsorted like now.
Just in case this pops up some time in the future: having separate tables
for includes and excludes is a really bad idea. We do not want to repeat
an apache http access-list mistake (a need for Order directive, inability to
express subranges within subranges), or a mistake from early implementation
of tcp_wrappers having two files, later fixed by adding hosts_options).
The lookup list must be only one, followed in a user-specified order, and
each entry must hold a boolean property (e.g. pass/block, allow/deny).
The patch is fine, an occasional duplicate does no harm.
+1
--
Configure bugmail:
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
