On Tue, Mar 3, 2009 at 00:05, Duncan Findlay <[email protected]> wrote: > > On Mar 2, 2009, at 3:48 PM, Apache Hudson Server wrote: >> >> See >> http://hudson.zones.apache.org/hudson/job/SpamAssassin-trunk/2776/changes > > According to > http://hudson.zones.apache.org/hudson/job/SpamAssassin-trunk/2776 my commit > broke the build because we run make test on the distributed files, and > mass-check isn't distributed. What's the best way to work around this? > Presumably we should skip reuse.t if masses/mass-check doesn't exist, but > that could indicate an error we want to fail on. Should it be made a config > option?
No, I think if (-e "masses/mass-check") fails, or maybe just if (-d "masses") fails, skip the test. That will be very obvious, and it's unlikely we could accidentally svn delete the entire masses directory without someone noticing. ;) > Also, I'm confused by this output: > http://hudson.zones.apache.org/hudson/job/SpamAssassin-trunk/2776/console > > It suggests that a couple of other tests failed as well, but these aren't > listed in the summary? > > Failed Test Stat Wstat Total Fail Failed List of Failed > ------------------------------------------------------------------------------- > t/config_tree_recurse.t 17 4352 4 8 200.00% 1-4 > t/whitelist_addrs.t 255 65280 35 44 125.71% 14-35 > 36 tests skipped. > Failed 2/152 test scripts, 98.68% okay. 26/3128 subtests failed, 99.17% > okay. > *** Error code 11 sounds like the summary-generation script fails to spot those failures! :( ok 13 Unknown open() mode '>&' at t/whitelist_addrs.t line 95. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 14-35 Failed 22/35 tests, 37.14% okay odd. I've opened that as https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6077 --j.
