On Mar 3, 2009, at 1:56 AM, Justin Mason wrote:

On Tue, Mar 3, 2009 at 00:05, Duncan Findlay <[email protected]> wrote:
According to
http://hudson.zones.apache.org/hudson/job/SpamAssassin-trunk/2776 my commit broke the build because we run make test on the distributed files, and mass-check isn't distributed. What's the best way to work around this? Presumably we should skip reuse.t if masses/mass-check doesn't exist, but that could indicate an error we want to fail on. Should it be made a config
option?

No, I think if (-e "masses/mass-check") fails, or maybe just if (-d
"masses") fails,
skip the test.  That will be very obvious, and it's unlikely we could
accidentally
svn delete the entire masses directory without someone noticing. ;)

Makes sense to me. I've fixed this in r749680. Sorry for all the build failure spam!

Duncan

Reply via email to