https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131





--- Comment #5 from [email protected]  2009-06-09 16:28:07 PST ---
(In reply to comment #3)
> SA's min perl version is 5.6.1 iirc....

SA can keep a min perl version of 5.6.1, I think, provided it has a min
MakeMaker  version of 6.11(?) rather than 5.45.  At a MINIMUM, the logic of the
hack can be fixed: shouldn't the logic be:

$mm_has_destdir      = $mm_knows_destdir || $mm_has_good_destdir

rather than:

$mm_has_destdir      = $mm_knows_destdir || $mm_needs_destdir;

? It doesn't make sense that the "has" is defined by "knows" or "needs" (the
latter suggests the opposite!) rather than "knows" or "has_good". I think that
logic may be the root of the hack's failure.  So even a short fix to address
the hack might be a small step, short of finding a better work-around that
isn't targeting MakeMaker's private internals.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to