https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6274

--- Comment #1 from Mark Martinec <[email protected]> 2010-01-07 08:40:23 
UTC ---
Created an attachment (id=4624)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4624)
proposed patch, but t/cross_user_config_leak.t still unfinished

Ok, this is how far I got. The patch introduces three new type constants:

  - $CONF_TYPE_NOARGS: must not have any argument, like "clear_headers"
  - $CONF_TYPE_STRINGLIST list of strings, stored as an array
  - $CONF_TYPE_IPADDRLIST list of IP addresses, stored as an array of
SA::NetSet

and adds the 'type => ...' declarations where missing and suitable,
even if a declaration provides its own parsing subroutine (which seems
to be the new practice which helps at a cross_user_config_leak.t test
and helps to document the setting).

The validation test in t/cross_user_config_leak.t for these three new types
still has some loose ends, mainly because I don't fully understand what
cloning is supposed to do with arrays and hashes in declaration options.
The call to assert_validation at line 212 in cross_user_config_leak.t
is commented out, otherwise the test fails. Please help getting the
cross_user_config_leak.t right (is a change to clone also necessary?)

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to