Done. The fact that it's the SAME files missing in the Makefile for
6304 that were missing from the SVN Snapshot for 6337 is my thought.
Not sure how the auto-snapshot process works, though to dig further.
On 3/1/2010 11:50 AM, Justin Mason wrote:
6304: if you want to put it in review, go for it. looks good
6337: I don't think that will fix the main issue there.
--j.
On Mon, Mar 1, 2010 at 16:15, Kevin A. McGrail<[email protected]> wrote:
I think 6304 is minor and could go to review as-is. I'd like to enhance it
more but that could be a future issue. However, the hi-jacked portion with
the change to the Makefile on that bug might fix the 6337 svn snapshot.
On 3/1/2010 11:02 AM, Justin Mason wrote:
ok, so my round up of those is as follows:
agreed, this is a must, please comment:
6335 Spamhaus DBL
another must, this needs 2 votes:
6294 RCVD_IN_CSS rule doesn't trigger
This is not ready, still apparent disagreement in comments:
6313 (a taint fix)
This is not vital -- could wait for a 3.3.2, doesn't fix a live bug:
6241 mkrules does not understand newer options and 'else'
These need 1 vote, not vital:
6310 (a taint fix)
6267 (mainly documenting the already existing functionality)
6072 (POD warnings - it's really ugly when 'man' complains
every time before showing a page)
6340 VPOPMAIL
These are not ready for review yet, so IMO won't make 3.3.1:
6271 FH_DATE_PAST_20XX rule should be dropped
6356 (Windows)
6337 (not fixed yet, svn snapshot not building)
--j.
On Mon, Mar 1, 2010 at 14:26, Kevin A. McGrail<[email protected]> wrote:
On 3/1/2010 8:02 AM, Mark Martinec wrote:
On Monday March 1 2010 11:32:32 Justin Mason wrote:
any bugs that we want to get into an impeding 3.3.1 release?
the DBL bug is just about ready to go, bar reviews.
must:
6335 Spamhaus DBL
6313 (a taint fix)
6241 mkrules does not understand newer options and 'else'
6310 (a taint fix)
6267 (mainly documenting the already existing functionality)
6072 (POD warnings - it's really ugly when 'man' complains
every time before showing a page)
I'd like to see also:
6294 RCVD_IN_CSS rule doesn't trigger
6271 FH_DATE_PAST_20XX rule should be dropped
6356 (Windows)
6340 VPOPMAIL
Many of the above are already in review mode.
Mark
On the ones i've been personally working on, I think 6337 is important
and
chains to the patch on 6304.
Regards,
KAM
