https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6304

--- Comment #8 from Mark Martinec <[email protected]> 2010-03-01 17:29:42 
UTC ---
> Needs 2 more votes to commit patch from comment 5

+1

Looks ok, with one nitpick:

> info("prefork: adjust: %s idle children more than %s maximum idle children.
>  Decreasing spamd children: $pid killed.", $num_idle, $self->{max_idle}, 
> $pid);

Please never mix the sprintf-style (format, with arguments) with classical
style (no arguments) of calls to info() and dbg().  As soon as extra arguments
are specified, the first one is interpreted as a sprintf format, and
interpolated
variables should generally not be allowed there (without a good reason).

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to